test(opencode): cover message ID rollover loop - #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the test-only follow-up to #149 and addresses the P3 Cubic review note. It does not change production behavior.
Verification
bun test test/session/prompt.test.ts -t 'nonmonotonic message IDs|message ID rollover'— 2 passedbun typecheckinpackages/opencode— passedSummary by cubic
Adds a regression test for the August 14 message‑ID rollover to ensure the prompt loop starts a new user turn instead of silently exiting. Previously the loop could exit when older completed turn IDs sorted above a newer user message; the test proves it now reaches provider model lookup for the newer turn.
Reviewer notes
rolloverNoLLMServertest case inpackages/opencode/test/session/prompt.test.ts.ProviderSvc.getModelto signal when model lookup begins.prompt.loopstarts the newer turn.Written for commit dbb9ba9. Summary will update on new commits.