Fix webhook signature verification to use original body#58
Open
Spirou7 wants to merge 1 commit intobrowser-use:mainfrom
Open
Fix webhook signature verification to use original body#58Spirou7 wants to merge 1 commit intobrowser-use:mainfrom
Spirou7 wants to merge 1 commit intobrowser-use:mainfrom
Conversation
The verifyWebhookEventSignature function was using event.data (the Zod-validated output) instead of json (the original parsed body) when computing the signature. This caused verification failures because Browser Use Cloud signs the raw body, but the SDK was signing the potentially transformed Zod output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyWebhookEventSignatureto compute signature using the original parsed JSON body instead of the Zod-validated outputProblem
The
verifyWebhookEventSignaturefunction was usingevent.data(the Zod-validated output) instead ofjson(the original parsed body) when computing the signature for verification. This caused signature verification failures because:Solution
Changed line 84 in
src/wrapper/lib/webhooks.tsfrom:To:
Test plan
🤖 Generated with Claude Code
Summary by cubic
Fixed webhook signature verification to use the original JSON body instead of the Zod-validated output. This matches Browser Use Cloud’s signing behavior and prevents verification failures.
Written for commit 113644f. Summary will update automatically on new commits.