Fix test suite compatibility with Python 3.12#154
Merged
debrado merged 1 commit intobraintree:masterfrom Nov 6, 2023
Merged
Conversation
Replace the deprecated `unittest.TestCase.assertRaisesRegexp()` method with `assertRaisesRegex()`. The former is no longer present in Python 3.12, while the latter is available since Python 3.2. Replace the deprecated `imp.reload()` function with `importlib.reload()`. The former module is no longer present in Python 3.12, while `importlib.reload()` is available since Python 3.4. With these changes, unit tests pass with Python 3.12.0. Fixes braintree#153
|
👋 @mgorny Thanks for the PR! We'll take a look and provide feedback. For internal tracking, issue 26930 |
debrado
added a commit
that referenced
this pull request
Nov 6, 2023
Fix test suite compatibility with Python 3.12 #154
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the deprecated
unittest.TestCase.assertRaisesRegexp()method withassertRaisesRegex(). The former is no longer present in Python 3.12, while the latter is available since Python 3.2.Replace the deprecated
imp.reload()function withimportlib.reload(). The former module is no longer present in Python 3.12, whileimportlib.reload()is available since Python 3.4.With these changes, unit tests pass with Python 3.12.0.
Fixes #153
Checklist
python3 -m unittest discover tests/unit)