Repository navigation
Fix error when selecting GridHeatMap cells (#1632) - #1710
Open
ChakriCherukuri wants to merge 1 commit into
Open
ChakriCherukuri wants to merge 1 commit into
ChakriCherukuri wants to merge 1 commit into
Conversation
Selecting a cell passed [[row, col]] through as an object array, which then failed to serialize back to the frontend. Keep rectangular numeric selections as real numeric arrays so they round-trip. Added tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a cell passed [[row, col]] through as an object array, which then failed to serialize back to the frontend. Keep rectangular numeric selections as real numeric arrays so they round-trip. Added tests.
References
Fixes #1632.
Code changes
Selecting a cell in a GridHeatMap sets
selectedto a rectangular list of[row, col] pairs (e.g. [[0, 1]]).
array_from_jsonforced dtype=object for anylist-of-lists, producing an object array that
array_to_jsonthen refused tore-serialize when ipywidgets echoed the trait back — raising
ValueError: Unsupported dtype object.User-facing changes
GridHeatMap cell selection no longer throws errors;
selectedattribute works correctly.Backwards-incompatible changes
None