Skip to content

Improve autocompletion of parameters#996

Merged
sebastinas merged 3 commits intobpython:mainfrom
gpotter2:main
Jul 26, 2023
Merged

Improve autocompletion of parameters#996
sebastinas merged 3 commits intobpython:mainfrom
gpotter2:main

Conversation

@gpotter2
Copy link
Copy Markdown
Contributor

@gpotter2 gpotter2 commented Jul 22, 2023

Two minor improvements to the completion:

  1. auto-completion for parameters is done without needing to pass the beggining of a parameter. To give an example:
class Test:
    def __init__(self, aaa, aab, aac):
        pass

with the PR: this allows to do: Test( then TAB directly to select the arguments
image

upstream/main: you need to do Test(a before completion kicks in. Test( gives nothing
image

  1. auto-completion results are ordered slightly differently: parameters should be prioritized when available.

this PR:
image

upstream/main:
image

@gpotter2 gpotter2 changed the title Improve autocompletion Improve autocompletion of parameters Jul 22, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 22, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.39%. Comparing base (7bf93f5) to head (77bed91).
⚠️ Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   76.35%   76.39%   +0.03%     
==========================================
  Files          61       61              
  Lines        8291     8302      +11     
==========================================
+ Hits         6331     6342      +11     
  Misses       1960     1960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebastinas sebastinas merged commit 9c83806 into bpython:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants