completion box size changes based on terminal size #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasballinger
force-pushed
the
size-dependent-scroll
branch
from
b666dcf to
0f54e73
Compare
thomasballinger
force-pushed
the
size-dependent-scroll
branch
from
0f54e73 to
aa4ff42
Compare
thomasballinger
changed the title
Member
Author
|
As @ikanobori suggested, I first tested the old behavior then checked it could be recreated in the old system, then changed the defaults to change behavior (see https://github.com/bpython/bpython/pull/618/files#diff-0f9439a6ef3e711e08826856e4ad77b8R699) |
Member
Author
|
pinging @sebastinas, any thoughts on this? It
Here's what the new behavior looks like: (gif is too fast, see https://asciinema.org/a/84660)
|
Member
Author
|
This gif reveals some possible bugs, but they're in both versions. I've created a new issue for this: #634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #466
Try to preserve n lines of history (
try_preserve_history_height) unless that space is needed to make the completion box m lines (min_infobox_height) long (provided there is content to fill it). If there's space in the terminal below the cursor to fill and infobox content to fill ti with, go ahead and fill it.TODO:
[x] - test desired behavior in each case
[x] - docstring describing this layout technique