Skip to content

Fix DELETE key not being recognized #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasballinger merged 1 commit into from
Jun 6, 2016
Merged

Fix DELETE key not being recognized #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bpython/curtsiesfrontend/manual_readline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def back_word(cursor_offset, line):
return (last_word_pos(line[:cursor_offset]), line)


@edit_keys.on('<PADDELETE>')
@edit_keys.on('<DELETE>')
Copy link
Contributor

@sebastinas sebastinas Jun 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this handle both DELETE and PADDELETE?

Copy link

@RafaAguilar RafaAguilar Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Manjaro Linux (Arch) <PADDELETE> doesn't worked either.

Pypi's package doesn't have this change.

Copy link
Member

@thomasballinger thomasballinger Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastinas Right now in curtsies there isn't a PADDELETE, but it wouldn't hurt to add it if paddelete should do this too.

def delete(cursor_offset, line):
return (cursor_offset,
line[:cursor_offset] + line[cursor_offset+1:])
Expand Down