Skip to content

fix run order-dependant test failure #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastinas merged 2 commits into from
Dec 6, 2015
Merged

fix run order-dependant test failure #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a108ee1
fix run order-dependant test failure
thomasballinger Dec 3, 2015
9966986
Document why invalidate_caches needed
thomasballinger Dec 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions bpython/test/test_curtsies_repl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@
from bpython.test import (FixLanguageTestCase as TestCase, MagicIterMock, mock,
builtin_target, unittest)

if py3:
from importlib import invalidate_caches
else:
def invalidate_caches():
"""Does not exist before Python 3.3"""


def setup_config(conf):
config_struct = config.Struct()
Expand Down Expand Up @@ -292,6 +298,20 @@ def setUp(self):
self.dont_write_bytecode = sys.dont_write_bytecode
sys.dont_write_bytecode = True

# Because these tests create Python source files at runtime,
# it's possible for the importlib.machinery.FileFinder for
# a directory to have an outdated cache in the following situation:
# * a module in that directory is imported,
# * then a new module is created in that directory,
# * then that new module is imported.
#
# invalidate_cache() is used to prevent this.
#
# see https://docs.python.org/3/library/importlib.html
# sections #importlib.machinery.FileFinder and
# #importlib.invalidate_caches
invalidate_caches()
Copy link
Contributor

@sebastinas sebastinas Dec 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please document why invalidate_caches is called here?


def tearDown(self):
sys.dont_write_bytecode = self.dont_write_bytecode

Expand Down