Add option to remove duplicates from history. (Closes: #135)

Sebastian Ramacher · Sebastian Ramacher · commit fa8e0b4f5acd · 2012-01-09T23:17:16.000+01:00
diff --git a/bpython/config.py b/bpython/config.py
@@ -61,6 +61,7 @@ def loadini(struct, configfile):
             'highlight_show_source': True,
             'hist_file': '~/.pythonhist',
             'hist_length': 100,
+            'hist_duplicates': True,
             'paste_time': 0.02,
             'syntax': True,
             'tab_length': 4,
@@ -110,6 +111,7 @@ def loadini(struct, configfile):
                                                      'highlight_show_source')
     struct.hist_file = config.get('general', 'hist_file')
     struct.hist_length = config.getint('general', 'hist_length')
+    struct.hist_duplicates = config.getboolean('general', 'hist_duplicates')
     struct.flush_output = config.getboolean('general', 'flush_output')
     struct.pastebin_key = config.get('keyboard', 'pastebin')
     struct.save_key = config.get('keyboard', 'save')
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -146,17 +146,25 @@ def writetb(self, lines):
 
 class History(object):
 
-    def __init__(self, entries=None):
+    def __init__(self, entries=None, duplicates=False):
         if entries is None:
             self.entries = ['']
         else:
             self.entries = list(entries)
         self.index = 0
         self.saved_line = ''
+        self.duplicates = duplicates
 
     def append(self, line):
         line = line.rstrip('\n')
         if line:
+            if not self.duplicates:
+                # remove duplicates
+                try:
+                    while True:
+                        self.entries.remove(line)
+                except ValueError:
+                    pass
             self.entries.append(line)
 
     def first(self):
@@ -340,7 +348,7 @@ def __init__(self, interp, config):
         self.interp = interp
         self.interp.syntaxerror_callback = self.clear_current_line
         self.match = False
-        self.rl_history = History()
+        self.rl_history = History(duplicates=config.hist_duplicates)
         self.s_hist = []
         self.history = []
         self.evaluating = False
