Remove bpython._py3compat.prepare_for_exec

sebastinas · sebastinas · commit e858ed1ca7c4 · 2020-10-13T21:17:53.000+02:00
diff --git a/bpython/_py3compat.py b/bpython/_py3compat.py
@@ -37,18 +37,6 @@
 py3 = sys.version_info[0] == 3
 
 
-if py3 or sys.version_info[:3] >= (2, 7, 3):
-
-    def prepare_for_exec(arg, encoding=None):
-        return arg
-
-
-else:
-
-    def prepare_for_exec(arg, encoding=None):
-        return arg.encode(encoding)
-
-
 if py3:
 
     def try_decode(s, encoding):
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -44,7 +44,7 @@
 
 from . import autocomplete
 from . import inspection
-from ._py3compat import py3, prepare_for_exec
+from ._py3compat import py3
 from .clipboard import get_clipboard, CopyFailed
 from .config import getpreferredencoding
 from .formatter import Parenthesis
@@ -1169,14 +1169,12 @@ def send_to_external_editor(self, text):
         exited with non-zero"""
 
         encoding = getpreferredencoding()
-        editor_args = shlex.split(
-            prepare_for_exec(self.config.editor, encoding)
-        )
+        editor_args = shlex.split(self.config.editor)
         with tempfile.NamedTemporaryFile(suffix=".py") as temp:
             temp.write(text.encode(encoding))
             temp.flush()
 
-            args = editor_args + [prepare_for_exec(temp.name, encoding)]
+            args = editor_args + [temp.name]
             if subprocess.call(args) == 0:
                 with open(temp.name) as f:
                     if py3:
@@ -1187,11 +1185,8 @@ def send_to_external_editor(self, text):
                 return text
 
     def open_in_external_editor(self, filename):
-        encoding = getpreferredencoding()
-        editor_args = shlex.split(
-            prepare_for_exec(self.config.editor, encoding)
-        )
-        args = editor_args + [prepare_for_exec(filename, encoding)]
+        editor_args = shlex.split(self.config.editor)
+        args = editor_args + [filename]
         return subprocess.call(args) == 0
 
     def edit_config(self):
