Log exceptions from auto completers

sebastinas · sebastinas · commit dc5e87fd91f3 · 2015-11-29T23:29:53.000+01:00
Also do not catch KeyboardInterrupt and SystemExit.

Signed-off-by: Sebastian Ramacher &lt;sebastian+dev@ramacher.at&gt;
diff --git a/bpython/autocomplete.py b/bpython/autocomplete.py
@@ -29,6 +29,7 @@
 import abc
 import glob
 import keyword
+import logging
 import os
 import re
 import rlcompleter
@@ -609,13 +610,18 @@ def get_completer(completers, cursor_offset, line, **kwargs):
             double underscore methods like __len__ in method signatures
     """
 
-    try:
-        for completer in completers:
+    for completer in completers:
+        try:
             matches = completer.matches(cursor_offset, line, **kwargs)
-            if matches is not None:
-                return sorted(matches), (completer if matches else None)
-    except:
-        pass
+        except Exception as e:
+            # Instead of crashing the UI, log exceptions from autocompleters.
+            logger = logging.getLogger(__name__)
+            logger.debug(
+                'Completer {} failed with unhandled exception: {}'.format(
+                    completer, e))
+            continue
+        if matches is not None:
+            return sorted(matches), (completer if matches else None)
 
     return [], None
 
