Add test coverage for has_attr_safe

rybarczykj · rybarczykj · commit 764927f0d5c3 · 2020-07-30T09:16:42.000-05:00
diff --git a/bpython/autocomplete.py b/bpython/autocomplete.py
@@ -537,7 +537,7 @@ def matches(self, cursor_offset, line, **kwargs):
         except EvaluationError:
             return set()
 
-        # strips leading dot
+         #          strips leading dot
         matches = [m[1:] for m in self.attr_lookup(obj, "", attr.word)]
         return set(m for m in matches if few_enough_underscores(attr.word, m))
 
diff --git a/bpython/test/test_inspection.py b/bpython/test/test_inspection.py
@@ -167,9 +167,14 @@ def test_lookup_on_object(self):
             self.assertEqual(get_attr_safe(b, "a"), "a")
             self.assertEqual(get_attr_safe(b, "b"), "b")
 
+            self.assertEqual(has_attr_safe(b, "y"), True)
+            self.assertEqual(has_attr_safe(b, "b"), True)
+
+
         def test_avoid_running_properties(self):
             p = Property()
             self.assertEqual(get_attr_safe(p, "prop"), Property.prop)
+            self.assertEqual(has_attr_safe(p, "prop"), True)
         
         def test_lookup_with_slots(self):
             s = Slots()
@@ -178,6 +183,8 @@ def test_lookup_with_slots(self):
             with self.assertRaises(AttributeError):
                 get_attr_safe(s, "s2")
 
+            self.assertEqual(has_attr_safe(s, "s2"), False)
+
         def test_lookup_on_slots_classes(self):
             sga = get_attr_safe
             s = SlotsSubclass()
@@ -186,6 +193,9 @@ def test_lookup_on_slots_classes(self):
             self.assertIsInstance(sga(SlotsSubclass, "s4"), property)
             self.assertIsInstance(sga(s, "s4"), property)
 
+            self.assertEqual(has_attr_safe(s, "s1"), True)
+            self.assertEqual(has_attr_safe(s, "s4"), True)
+
         @unittest.skipIf(py3, "Py 3 doesn't allow slots and prop in same class")
         def test_lookup_with_property_and_slots(self):
             sga = get_attr_safe
@@ -206,6 +216,12 @@ def test_lookup_on_overridden_methods(self):
             with self.assertRaises(AttributeError):
                 sga(OverriddenMRO(), "b")
 
+            self.assertEqual(has_attr_safe(OverriddenGetattr(), "b"), False)
+            self.assertEqual(has_attr_safe(OverriddenGetattribute(), "b"), False)
+            self.assertEqual(has_attr_safe(OverriddenMRO(), "b"), False)
+            
+
+
 
 if __name__ == "__main__":
     unittest.main()
