Read in the history file before writing. This prevents stomping of history from multiple bpython sessions. History from multiple sessions will be interleaved.

amjith · amjith · commit 33e4c44c0876 · 2011-04-28T20:29:40.000-04:00
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -745,12 +745,13 @@ def push(self, s, insert_into_history=True):
         s = s.rstrip('\n')
         self.buffer.append(s)
 
-
-        if insert_into_history:
+        if insert_into_history and self.config.hist_length:
+            histfilename = os.path.expanduser(self.config.hist_file)
+            self.rl_history.entries = []
+            if os.path.exists(histfilename):
+                self.rl_history.load(histfilename, getpreferredencoding())
             self.rl_history.append(s)
-            if self.config.hist_length:
-                histfilename = os.path.expanduser(self.config.hist_file)
-                self.rl_history.save(histfilename, getpreferredencoding(), self.config.hist_length)
+            self.rl_history.save(histfilename, getpreferredencoding(), self.config.hist_length)
 
         more = self.interp.runsource('\n'.join(self.buffer))
 
