Make it so we setting hist_length to zero does not cause you to not have session history

ikanobori · ikanobori · commit 023402d062ea · 2011-04-29T12:50:35.000+02:00
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -745,16 +745,19 @@ def push(self, s, insert_into_history=True):
         s = s.rstrip('\n')
         self.buffer.append(s)
 
-        if insert_into_history and self.config.hist_length:
-            histfilename = os.path.expanduser(self.config.hist_file)
-            self.rl_history.entries = []
-            if os.path.exists(histfilename):
-                self.rl_history.load(histfilename, getpreferredencoding())
-            self.rl_history.append(s)
-            try:
-                self.rl_history.save(histfilename, getpreferredencoding(), self.config.hist_length)
-            except EnvironmentError as (errno, strerr):
-                self.interact.notify("Write error for file: %s. %s " % (histfilename, strerr))
+        if insert_into_history:
+            if self.config.hist_length:
+                histfilename = os.path.expanduser(self.config.hist_file)
+                self.rl_history.entries = []
+                if os.path.exists(histfilename):
+                    self.rl_history.load(histfilename, getpreferredencoding())
+                self.rl_history.append(s)
+                try:
+                    self.rl_history.save(histfilename, getpreferredencoding(), self.config.hist_length)
+                except EnvironmentError as (errno, strerr):
+                    self.interact.notify("Write error for file: %s. %s " % (histfilename, strerr))
+            else:
+                self.rl_history.append(s)
 
         more = self.interp.runsource('\n'.join(self.buffer))
 
