Replace with $( ) inside strings and in commands#77
Merged
jwerle merged 3 commits intobpkg:masterfrom Feb 6, 2017
Merged
Conversation
jwerle
reviewed
Jan 31, 2017
lib/update/update.sh
Outdated
| ;; | ||
| esac | ||
| done | ||
| done } |
Contributor
Author
There was a problem hiding this comment.
I forgot to remove the {}
You're right, it doesn't make any sense.
| @@ -1 +1,3 @@ | |||
| {"key":"hello this is a string"} No newline at end of file | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
It's the way JSON files needs to be formatted according to the convention.
- it doesn't interfere with the content of the JSON file.
Member
There was a problem hiding this comment.
I understand that. However, the JSON implementation is an upstream of https://github.com/dominictarr/JSON.sh and should not be modified.
Contributor
Author
There was a problem hiding this comment.
Oh, I see.
I didn't know that. Maybe you should mention it in credit section in the ReadMe file !
I'll drop the changes to the JSON files in lib/json.
Member
|
@abdelkafiahmed thank you! |
dzuelke
reviewed
Mar 1, 2017
| eval local val="\${${key}}" | ||
| [ -z "${val}" ] && error "Missing \`${key}' property" | ||
| [ -z "${val}" ] && error "Missing \` | ||
| ${key}' property" |
Contributor
Author
There was a problem hiding this comment.
No it's not intentional !! My bad !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced