Replace basestring with six.string_types#90
Merged
Jeff-Meadows merged 1 commit intomasterfrom Nov 16, 2015
Merged
Conversation
|
Verified that @jmoldow has signed the CLA. Thanks for the pull request! |
jmoldow
force-pushed
the
replace_basestring
branch
from
d9fd2da to
3b2084c
Compare
On Python 3, calling `setup_logging()` in `boxsdk.util.log`
would always raise
NameError: name 'basestring' is not defined
On Python 3, this prevented `LoggingNetwork` from being
initialized without passing an existing `Logger`.
Replace this usage of `basestring` with the equivalent
`six.string_types`.
Add unit test coverage of `boxsdk.util.log`.
Bump version to 1.3.2.
jmoldow
force-pushed
the
replace_basestring
branch
from
3b2084c to
a66da09
Compare
Jeff-Meadows
added a commit
that referenced
this pull request
Nov 16, 2015
Replace `basestring` with `six.string_types`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3, calling
setup_logging()inboxsdk.util.logwould always raise
On Python 3, this prevented
LoggingNetworkfrom beinginitialized without passing an existing
Logger.Replace this usage of
basestringwith the equivalentsix.string_types.Add unit test coverage of
boxsdk.util.log.Bump version to 1.3.2.