Closed
Conversation
Hi ! Dear Sir/Mam I am Vaibhav from India . I have Participated in the "HacktoberFest 2020" . So i am helping some Open Source by fixing spells or adding important signs . I have not edited that much but it would be better If you Accept my pull request . Regards , Vaibhav Mishra
|
|
|
Hi @vaibhav623 . Thank you for this PR but I'm not sure what this is supposed to achieve. Most of these changes are not really adding anything to the project or the docs. I see that this is part of Hacktoberfest and I'd like to point you at the Hacktoberfest values and remind you that quality is key. https://hacktoberfest.digitalocean.com/details#values I am going to close this PR for now but please feel free to re-open with more details regarding the reason for the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ! Dear Sir/Mam
I am Vaibhav from India . I have Participated in the "HacktoberFest 2020" . So i am helping some Open Source by fixing spells or adding important signs . I have not edited that much but it would be better If you Accept my pull request .
Regards ,
Vaibhav Mishra