Fix bug with updating a collaboration role to owner#536
Merged
sujaygarlanka merged 7 commits intomasterfrom Sep 14, 2020
Merged
Fix bug with updating a collaboration role to owner#536sujaygarlanka merged 7 commits intomasterfrom
sujaygarlanka merged 7 commits intomasterfrom
Conversation
Pull Request Test Coverage Report for Build 2271
💛 - Coveralls |
PJSimon
previously approved these changes
Sep 10, 2020
PJSimon
previously approved these changes
Sep 11, 2020
PJSimon
approved these changes
Sep 14, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address issue #528. When a collaboration role is updated to an owner, the endpoint returns a 204 with no JSON response instead of the 200 with a JSON response that all other updates return. The SDK was throwing an error when a 204 is returned and this PR addresses the issue.
Wrote an automated test and did manual testing.