Skip to content

Commit cdc141d

Browse files
64json64json
committed
fix bug where index 0 was not updated in ChartTracer
1 parent 1d6fb9a commit cdc141d

File tree

6 files changed

+12
-9
lines changed

6 files changed

+12
-9
lines changed

‎algorithm/sorting/bubble/basic/data.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
var tracer = new Array1DTracer();
1+
var chart = new ChartTracer();
2+
var tracer = new Array1DTracer().attach(chart);
23
var logger = new LogTracer();
34
var D = Array1D.random(15);
45
tracer._setData(D);

‎js/module/tracer/array1d.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,9 @@ class Array1DTracer extends Array2DTracer {
4444
if (this.chartTracer) {
4545
const newStep = $.extend(true, {}, step);
4646
newStep.capsule = this.chartTracer.capsule;
47-
newStep.s = newStep.y || newStep.sy;
47+
newStep.s = newStep.sy;
4848
newStep.e = newStep.ey;
49+
if (newStep.s === undefined) newStep.s = newStep.y;
4950
delete newStep.x;
5051
delete newStep.y;
5152
delete newStep.sx;

‎public/algorithm_visualizer.js‎

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎public/algorithm_visualizer.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎public/algorithm_visualizer.min.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎public/algorithm_visualizer.min.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)