Skip to content

add granular display of tests in the failed step #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waseem-medhat merged 1 commit into from
Jan 22, 2026
Merged

add granular display of tests in the failed step #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions checks/checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,36 +223,48 @@ func sendHTTPRequestResults(ch chan tea.Msg, req api.CLIStepHTTPRequest, result

func ApplySubmissionResults(cliData api.CLIData, failure *api.VerificationResultStructuredErrCLI, ch chan tea.Msg) {
for i, step := range cliData.Steps {
pass := true
stepPass := true
isFailedStep := false
if failure != nil {
pass = i < failure.FailedStepIndex
stepPass = i < failure.FailedStepIndex
isFailedStep = i == failure.FailedStepIndex
}

ch <- messages.ResolveStepMsg{
Index: i,
Passed: &pass,
Passed: &stepPass,
}

if step.CLICommand != nil {
for j := range step.CLICommand.Tests {
if isFailedStep && j > failure.FailedTestIndex {
break
}

testPass := stepPass || (isFailedStep && j < failure.FailedTestIndex)
ch <- messages.ResolveTestMsg{
StepIndex: i,
TestIndex: j,
Passed: &pass,
Passed: &testPass,
}
}
}
if step.HTTPRequest != nil {
for j := range step.HTTPRequest.Tests {
if isFailedStep && j > failure.FailedTestIndex {
break
}

testPass := stepPass || (isFailedStep && j < failure.FailedTestIndex)
ch <- messages.ResolveTestMsg{
StepIndex: i,
TestIndex: j,
Passed: &pass,
Passed: &testPass,
}
}
}

if !pass {
if !stepPass {
break
}

Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.23.1
v1.23.2