Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode)#518
Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode)#518stephengtuggy wants to merge 8 commits into
Conversation
stephengtuggy
changed the title
|
thanks @stephengtuggy for the patch ! It's definitely a step in the right direction, but apparently not yet complete (the build fails). |
…sed to the `faber` commands
@stefanseefeld you're welcome. I think I see what the problem is. I neglected to update the include directory passed to the |
|
Nope, still not right. And unfortunately, this may not be trivial to fix. I'm not sure if there is a singular Boost include directory that can be passed to faber. I think it may be more like a different include directory for each Boost component. How to handle this situation? |
…ed for `vcpkgGitCommitId` prior to this PR
|
To eliminate a variable, I am going back to the same vcpkg baseline in the manifest file as was used for |
| vcpkgDirectory: '${{ github.workspace }}/vcpkg' | ||
| runVcpkgInstall: true | ||
| - name: List directory contents | ||
| run: Get-ChildItem "${{ github.workspace }}/vcpkg" -Recurse -Force -File -Filter 'config.hpp' |
There was a problem hiding this comment.
Perhaps if you use -User . to start looking in the local directory instead of $github.workspace/vcpkg ?
Alternatively, I see that the install root can be set via the vcpkgArguments: '--x-manifest-root=${{ github.workspace }}/vcpkg' directive.
There was a problem hiding this comment.
This command simply searches the <github workspace>/vcpkg directory and all subdirectories for a file named config.hpp. It is literally the equivalent of find "${{ github.workspace}}/vcpkg" -iname 'config.hpp' -type f. And it's not finding the file anywhere! I don't understand what is going on here. Why would this file not be present?
I'm not familiar with -User . in conjunction with the Get-ChildItem command. What would that do?
There was a problem hiding this comment.
Yes, the install root can be set using the vcpkgArguments parameter, but I'm not sure it's best practice to do so.
|
It occurs to me that in my other projects that use vcpkg, I generally set the |
…ects that use vcpkg
2 participants
Fixes #514 (hopefully)