Bug 13078 - Management Server does not respect selected OS Preference for any host within a single pod.

prachi · prachi · commit be04ff861c1c · 2012-01-19T16:59:38.000-08:00
Changes:
- Once the HostAllocators have listed suitable hosts, planner should not reshuffle the list since that would lose the prioritization applied by the HostAllocators.
- E.g: HostAllocators chooses that host first which matches the guest OS category. If planner shuffles the list, that preferrence is lost.
diff --git a/server/src/com/cloud/deploy/FirstFitPlanner.java b/server/src/com/cloud/deploy/FirstFitPlanner.java
@@ -19,7 +19,6 @@
 package com.cloud.deploy;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.Enumeration;
 import java.util.HashMap;
 import java.util.List;
@@ -52,7 +51,6 @@
 import com.cloud.host.HostVO;
 import com.cloud.host.Status;
 import com.cloud.host.dao.HostDao;
-import com.cloud.host.dao.HostDetailsDao;
 import com.cloud.hypervisor.Hypervisor.HypervisorType;
 import com.cloud.offering.ServiceOffering;
 import com.cloud.org.Cluster;
@@ -519,9 +517,6 @@ private DeployDestination checkClustersforDestination(List<Long> clusterList, Vi
                     return dest;
                 }
 
-                if (_allocationAlgorithm != null && _allocationAlgorithm.equalsIgnoreCase("random")) {
-                    Collections.shuffle(suitableHosts);
-                }
                 Pair<Map<Volume, List<StoragePool>>, List<Volume>> result = findSuitablePoolsForVolumes(vmProfile, potentialPlan, avoid, StoragePoolAllocator.RETURN_UPTO_ALL);
                 Map<Volume, List<StoragePool>> suitableVolumeStoragePools = result.first();
                 List<Volume> readyAndReusedVolumes = result.second();
