refactor: Parsing adr poc url#259
Draft
ashearin wants to merge 5 commits into
Draft
Conversation
Minder Vulnerability Report ✅Minder analyzed this PR and found it does not add any new vulnerable dependencies.
|
d83be63 to
bf37dd5
Compare
bf37dd5 to
8cebe63
Compare
ashearin
commented
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proof of concept for 2 items:
The URL standard is the closest to what bomctl currently uses and was the logical first choice for a Proof of Concept. The command URL is largely the same as currently utilized, however any custom elements are being removed and moved into a url compliant field. example below reworks this command url in the currently implemented format:
-
https://username:password@github.com:12345/bomctl/bomctl.git@main#sbom.cdx.jsonMain difference is the
@mainused to designate the branch is moved into the query field. Another option is removing it entirely and creating a branch flag and defaulting to the default branch if a branch is not provided (although this may only be applicable to the git client)Optional improvements to what is changed, specifically in OCI client: (Can be implemented in separate issues)
prepareFetchandpreparePushcreateRepositoryin OCI client