Conversation
Adds completion config support and moves some things to the shared module. There will be a better way to share logic between these two even more but it hasn't yet clicked in my head.
|
commit: |
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
this looks good, i'm just wondering about why the function should be async tho?
|
Basically we need to decide if these various implementations should share an interface or not for their signature Option 1 - each integration has its own interface, this becomes sync. They will share things under the hood but have their own function type Option 2 - all integrations export the same type ( I'd like to do option 2 but that depends on if all callers can handle it being async |
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
thanks for the clarification James! 😁
3 participants
Adds completion config support and moves some things to the shared module.
There will be a better way to share logic between these two even more but it hasn't yet clicked in my head.