-
Notifications
You must be signed in to change notification settings - Fork 169
feat(core, prompts): add DatePrompt for date input with customizable formats #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fc7301f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
natemoo-re
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Left a few comments—happy to clarify if anything doesn't make sense.
|
I'm really liking this so far, but I have a few thoughts
|
|
it'd be good to render so it goes like this:
etc |
|
Thanks everyone for your feedback so far 😄 |
|
i've tested this locally and i don't get any errors, which is weird. I think the CI is failling due to the internal value i set with so:
also maybe snapshots were created on my local env (14), while CI (UTC) produced 15, so the snapshot comparison failed. i might need to think about fixing this in the upcoming days. |
Implements a date prompt that enforces a structured date format and supports the most common variants:
YYYY/MM/DD,MM/DD/YYYY, andDD/MM/YYYY.related: #447