updated to work with the code in the latest PH version

g-p-g · g-p-g · commit efe8a8d8defa · 2015-02-27T16:27:46.000-05:00
diff --git a/src/BurndownController.php b/src/BurndownController.php
@@ -50,7 +50,7 @@ public function processRequest() {
       $tasks_table    = $data->buildTasksTable();
       $events_table   = $data->buildEventTable();
     } catch (BurndownException $e) {
-      $error_box = id(new AphrontErrorView())
+      $error_box = id(new PHUIErrorView())
         ->setTitle(pht('Burndown could not be rendered for this project'))
         ->setErrors(array($e->getMessage()));
     }
diff --git a/src/BurndownData.php b/src/BurndownData.php
@@ -70,6 +70,7 @@ public function __construct($project, $viewer) {
     $tasks = id(new ManiphestTaskQuery())
       ->setViewer($viewer)
       ->withAnyProjects(array($this->project->getPHID()))
+      ->needProjectPHIDs(true)
       ->execute();
 
     // Now load *every transaction* for those tasks. This loads all the
@@ -440,8 +441,8 @@ public function buildTasksTable() {
    */
   private function buildTasksTree() {
     // Shorter constants
-    $DEPENDS_ON = PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK;
-    $DEPENDED_ON = PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK;
+    $DEPENDS_ON = ManiphestTaskDependsOnTaskEdgeType::EDGECONST;
+    $DEPENDED_ON = ManiphestTaskDependedOnByTaskEdgeType::EDGECONST;
 
     // Load all edges of depends and depended on tasks
     $edges = id(new PhabricatorEdgeQuery())
@@ -693,4 +694,4 @@ private function extractEvents($xactions, array $scope_phids) {
     return $events;
   }
 
-}
+}
diff --git a/src/SprintTaskStoryPointsField.php b/src/SprintTaskStoryPointsField.php
@@ -43,17 +43,27 @@ public function getStandardCustomFieldNamespace() {
   public function showField() {
     static $show = null;
 
-    if ($show == null)
-    {
-      $toTest = $this->getObject()->getProjectPHIDs();
-      if (empty($toTest)) {
+    $viewer = $this->getViewer();
+
+    if ($show == null) {
+      $id = $this->getObject()->getID();
+      $task = id(new ManiphestTaskQuery())
+          ->setViewer($viewer)
+	  ->withIds(array($id))
+	  ->needProjectPHIDs(true)
+	  ->executeOne();
+      if (!($task instanceof ManiphestTask)) {
+        return $show = false;
+      }
+      $project_phids = $task->getProjectPHIDs();
+      if (empty($project_phids)) {
         return $show = false;
       }
       // Fetch the names from all the Projects associated with this task
       $projects = id(new PhabricatorProject())
         ->loadAllWhere(
         'phid IN (%Ls)',
-        $this->getObject()->getProjectPHIDs());
+        $project_phids);
       $names = mpull($projects, 'getName');
 
       // Set show to true if one of the Projects contains "Sprint"

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function processRequest() {`
`50`	`50`	`$tasks_table = $data->buildTasksTable();`
`51`	`51`	`$events_table = $data->buildEventTable();`
`52`	`52`	`} catch (BurndownException $e) {`
`53`		`- $error_box = id(new AphrontErrorView())`
	`53`	`+ $error_box = id(new PHUIErrorView())`
`54`	`54`	`->setTitle(pht('Burndown could not be rendered for this project'))`
`55`	`55`	`->setErrors(array($e->getMessage()));`
`56`	`56`	`}`