Skip to content

Commit 160a70a

Browse files
author
stonebig
committed
QT_API setting is now dynamic
1 parent b9dd8bd commit 160a70a

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

make.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,6 @@ def __init__(self, build_number, release_level, target, wheeldir,
126126
self.rootdir = rootdir # addded to build from winpython
127127
self.install_options = install_options
128128
self.flavor = flavor
129-
self.QT_API='pyqt' # default Qt4
130-
import glob
131-
if len(glob.glob(osp.join(self.wheeldir, 'PyQt5*.*'))) > 0:
132-
self.QT_API='pyqt5' # force Qt5 on Spyder
133-
print('QT_API is "%s"' % self.QT_API)
134129

135130
@property
136131
def package_index_wiki(self):
@@ -341,8 +336,7 @@ def create_launcher(self, name, icon, command=None,
341336
data += [('R_HOME', '$EXEDIR%s' % r'\tools\R'),
342337
('JULIA_PKGDIR', '$EXEDIR%s' % r'\settings\.julia'),
343338
('JULIA_HOME', '$EXEDIR%s' % r'\tools\Julia\bin'),
344-
('JULIA', '$EXEDIR%s' % r'\tools\Julia\bin\julia.exe'),
345-
('QT_API', '%s' % self.QT_API)]
339+
('JULIA', '$EXEDIR%s' % r'\tools\Julia\bin\julia.exe')]
346340

347341
if settingspath is not None:
348342
data += [('SETTINGSDIR', osp.dirname(settingspath)),
@@ -616,8 +610,8 @@ def _create_batch_scripts_initial(self):
616610
617611
set PATH=""" + path + """
618612
619-
rem force default Qt kit for Spyder
620-
set QT_API=""" + self.QT_API)
613+
rem force default pyqt5 kit for Spyder if PyQt5 module is there
614+
if exist %WINPYDIR%\Lib\site-packages\PyQt5 set QT_API=pyqt5""")
621615

622616
def _create_batch_scripts(self):
623617
"""Create batch scripts"""

portable/launcher.nsi

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ Licensed under the terms of the MIT License
2121
!define JULIA ""
2222
; Addition for JULIA_PKGDIR
2323
!define JULIA_PKGDIR ""
24-
; Addition for QT_API(used by Spyder)
25-
!define QT_API ""
2624

2725
!define COMMAND ""
2826
!define PARAMETERS ""
@@ -91,10 +89,9 @@ System::Call 'Kernel32::SetEnvironmentVariableA(t, t) i("JULIA_PKGDIR", "${JULIA
9189
end_Julia_settings:
9290

9391

94-
; Addition for QT_API if Qt5 detected
95-
StrCmp "${QT_API}" "" end_QT_API_settings
92+
; Addition for QT_API=pyqt5 if Qt5 detected
9693
IfFileExists "${WINPYDIR}\Lib\site-packages\PyQt5\*.*" 0 end_QT_API_settings
97-
System::Call 'Kernel32::SetEnvironmentVariableA(t, t) i("QT_API", "${QT_API}").r0'
94+
System::Call 'Kernel32::SetEnvironmentVariableA(t, t) i("QT_API", "pyqt5").r0'
9895

9996
end_QT_API_settings:
10097

0 commit comments

Comments
 (0)