Fixed argument value bleed into the next empty argument#19
Merged
nfedyk merged 3 commits intobitsofinfo:masterfrom Sep 19, 2025
Merged
Fixed argument value bleed into the next empty argument#19nfedyk merged 3 commits intobitsofinfo:masterfrom
nfedyk merged 3 commits intobitsofinfo:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where empty string arguments were being populated with values from previous arguments in PowerShell command generation. The fix initializes the valueToSet variable to an empty string to prevent value bleeding.
- Fixes argument value bleeding by initializing
valueToSetto empty string - Adds comprehensive test coverage for the empty argument scenario
- Includes test commands for file operations to validate the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| psCommandService.js | Initializes valueToSet variable to prevent argument value bleeding |
| test/unit.js | Adds test commands and test case to verify empty argument handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bmudda-wpp
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing the command with an empty string argument the generated PowerShell command incorrectly includes the value for the previous argument as value for the current one,
Expected Behavior:
When argument is an empty string (""), it should be omitted from the generated command
When argument is undefined, it should be omitted from the generated command
Only when argument has a meaningful value should it appear in the command
Actual Behavior:
Empty argument gets populated with the value of the previous argument.
Test Cases Demonstrating the Bug:
is expected to generate output:
Set-Content -Path './test.txt' -Value 'Test'actual result:
Set-Content -Path './test.txt' -Value 'Test' -Filter 'Test'Test has been updated to cover the fix for this scenario.