Skip to content

Fixed argument value bleed into the next empty argument#19

Merged
nfedyk merged 3 commits intobitsofinfo:masterfrom
nfedyk:fix/param-value-bleading
Sep 19, 2025
Merged

Fixed argument value bleed into the next empty argument#19
nfedyk merged 3 commits intobitsofinfo:masterfrom
nfedyk:fix/param-value-bleading

Conversation

@nfedyk
Copy link
Copy Markdown
Collaborator

@nfedyk nfedyk commented Sep 19, 2025

When executing the command with an empty string argument the generated PowerShell command incorrectly includes the value for the previous argument as value for the current one,

Expected Behavior:
When argument is an empty string (""), it should be omitted from the generated command
When argument is undefined, it should be omitted from the generated command
Only when argument has a meaningful value should it appear in the command

Actual Behavior:
Empty argument gets populated with the value of the previous argument.

Test Cases Demonstrating the Bug:

psCommandService.execute("setContent", {
        Path: "./test.txt",
        Value: "Test",
        Filter: ""
})

is expected to generate output:
Set-Content -Path './test.txt' -Value 'Test'

actual result:
Set-Content -Path './test.txt' -Value 'Test' -Filter 'Test'

Test has been updated to cover the fix for this scenario.

@nfedyk nfedyk requested a review from Copilot September 19, 2025 15:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where empty string arguments were being populated with values from previous arguments in PowerShell command generation. The fix initializes the valueToSet variable to an empty string to prevent value bleeding.

  • Fixes argument value bleeding by initializing valueToSet to empty string
  • Adds comprehensive test coverage for the empty argument scenario
  • Includes test commands for file operations to validate the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
psCommandService.js Initializes valueToSet variable to prevent argument value bleeding
test/unit.js Adds test commands and test case to verify empty argument handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

nfedyk and others added 2 commits September 19, 2025 11:23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nfedyk nfedyk merged commit ad374a0 into bitsofinfo:master Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants