for intel xpu case, use MatMul8bitFp even not use ipex#1728
Merged
matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom Sep 3, 2025
Merged
for intel xpu case, use MatMul8bitFp even not use ipex#1728matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom
matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom
Conversation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
|
@matthewdouglas , could u pls help review, it will make int8 LoRA finetuning loss overflow to |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Hi @yao-matrix |
matthewdouglas
previously approved these changes
Sep 2, 2025
|
@matthewdouglas , thx very much. |
Contributor
Author
|
@matthewdouglas thx for the reminder, should have fixed it. |
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
Mhmd-Hisham
pushed a commit
to Mhmd-Hisham/bitsandbytes
that referenced
this pull request
Sep 4, 2025
…foundation#1728) * for intel xpu case, use MatMul8bitFp even not use ipex Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> * fix lint issue Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com> --------- Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Intel XPU case, use
MatMul8bitFpis faster thanMatMul8bitLt. And it can avoid the datatype overflow issue in L105