Feature/dont auth invoice endpoint#18
Merged
kleetus merged 6 commits intobitpay:masterfrom Apr 6, 2016
Merged
Conversation
…l signing the requests and therefore not actually using the public API. This doesn't work in some cases because the /invoice endpoint doesn't support some facades. Also refactors some of the parameter building to off-the-shelf apache commons methods
…lder I'll contribute this in a later pull request
…nges due to bitcoinj 13
- As per mrosseel's pom file, conversion of all dependencies to use maven2. This will ease the pain of managing a bunch of jar files in lib - Repaired some deprecation warnings in bitcoinj dependency around Sha256 creation and ECKey construction. - Adjusted test harness to create tokens for pos/merchant facade, this is done once the first time someone runs the tests. The test runner just has to pair with their test account. The tester is does not have cascading test failures that might confuses as to what he/she needs to do. - Added some notes about how to do the refund test.
- Added constructors for passing the URI of your private key. We prefer to have users of this library pass in a URI for their key file. That way, this api isn't just writing new key files to the current working directory. If the URI does not have a key already, one will be created there (if writeable). It will be the user's responsibility to safeguard their private keys. - A bit of code cleanup in terms of spelling and removal of warnings, etc.
|
<3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10