Fix PDBList URL construction for non-RCSB Mirrors#5157
Open
kirandharmar867-maker wants to merge 1 commit intobiopython:masterfrom
Open
Fix PDBList URL construction for non-RCSB Mirrors#5157kirandharmar867-maker wants to merge 1 commit intobiopython:masterfrom
kirandharmar867-maker wants to merge 1 commit intobiopython:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5157 +/- ##
==========================================
+ Coverage 85.51% 86.41% +0.89%
==========================================
Files 282 282
Lines 59480 59480
==========================================
+ Hits 50867 51400 +533
+ Misses 8613 8080 -533 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes URL Construction in PDBList so it works correctly With non-RCSB PDB mirrors.
What was changed :
Why This needed :
Some PDB mirrors (ex: EBl) use a Different Directory layout and do not work With hardcoded /pub/pdb paths.
by moving the prefix into the server root, PDBList now works consistently across Mrirors.
issue reference:
Fixes #3987
Scope:
this PR is only addresses URL Path construction as described in the issue.