Add timeout support to NCBIWWW.qblast#5152
Open
dipankatanu wants to merge 5 commits intobiopython:masterfrom
Open
Add timeout support to NCBIWWW.qblast#5152dipankatanu wants to merge 5 commits intobiopython:masterfrom
dipankatanu wants to merge 5 commits intobiopython:masterfrom
Conversation
mdehoon
reviewed
Jan 26, 2026
| handle = urlopen(request) | ||
| # Adding a timeout | ||
| handle = urlopen(request, timeout=timeout) | ||
| # handle = urlopen(request) |
Contributor
There was a problem hiding this comment.
Please remove the comment lines.
Can the timeout parameter also be added to the qblast function in Bio/Blast/__init__.py?
Member
|
You need to remove the PDB changes too, which look to be from #5149 (a duplicate of work on another PR just merged giving the conflict here now). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added an optional timeout parameter to the qblast function to prevent infinite hangs during network requests. This allows users to specify a timeout (in seconds) that is passed directly to urllib.request.urlopen.