make sure that polar_angle is initialized even if the radius is zero,…#5127
Open
mdehoon wants to merge 2 commits intobiopython:masterfrom
Open
make sure that polar_angle is initialized even if the radius is zero,…#5127mdehoon wants to merge 2 commits intobiopython:masterfrom
mdehoon wants to merge 2 commits intobiopython:masterfrom
Conversation
… otherwise we will get a random value in polar_angle
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5127 +/- ##
==========================================
+ Coverage 85.51% 86.41% +0.89%
==========================================
Files 282 282
Lines 59493 59493
==========================================
+ Hits 50878 51412 +534
+ Misses 8615 8081 -534 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The linter says: This might be in error, but can you avoid double indexing these arrays with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… otherwise we will get a random value in polar_angle.
This is flagged with a warning in recent versions of numpy
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runpre-commitlocally, and understand that continuous integration checks will be used to
confirm the Biopython unit tests and style checks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)