chore: add type annotation to Bio/File.py#5088
Open
szabgab wants to merge 1 commit intobiopython:masterfrom
Open
chore: add type annotation to Bio/File.py#5088szabgab wants to merge 1 commit intobiopython:masterfrom
szabgab wants to merge 1 commit intobiopython:masterfrom
Conversation
Member
|
That's just a tiny fraction of the module - and a private bit of the API too - did you do more but forgot to push the work to GitHub? |
Author
|
I thought smaller PRs would make it easier to review and accept. |
Member
|
For type annotation, please do at least a whole file. Or most of it. |
szabgab
force-pushed
the
szabgab/type-annotations-file
branch
from
fd22de7 to
e0ab915
Compare
Author
|
OK. I have made some progress. This still needs more work. |
peterjc
reviewed
Oct 30, 2025
|
|
||
| from typing_extensions import TypeAlias | ||
| from typing import Callable | ||
| from _typeshed import FileDescriptorOrPath |
Member
There was a problem hiding this comment.
That's not in the standard library - see ModuleNotFoundError: No module named '_typeshed' errors in the CI testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runpre-commitlocally, and understand that continuous integration checks will be used to
confirm the Biopython unit tests and style checks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)
Addresses #2236 and does not touch files that are addressed in #5057