Add __next__ method to FastaTwoLineIterator#5078
Open
vihaankulkarni29 wants to merge 1 commit intobiopython:masterfrom
Open
Add __next__ method to FastaTwoLineIterator#5078vihaankulkarni29 wants to merge 1 commit intobiopython:masterfrom
vihaankulkarni29 wants to merge 1 commit intobiopython:masterfrom
Conversation
vihaankulkarni29
force-pushed
the
fix-fasta-iterator-3988
branch
from
6b28c98 to
4162970
Compare
peterjc
reviewed
Oct 15, 2025
| """ | ||
| super().__init__(source, fmt="FASTA") | ||
| self._data = FastaTwoLineParser(self.stream) | ||
| self.records = self._generate_records() |
Member
There was a problem hiding this comment.
I don't like making a new public attribute here (other parsers won't do this).
Contributor
There was a problem hiding this comment.
Yes this should be a private attribute
Member
|
Also I think you linked to the wrong issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR adds the explicit
__next__method to theFastaTwoLineIteratorclass, addressing issue #3988. This makes the class a more complete and explicit iterator.I have run the test suite locally. The isolated tests for the
Bio.SeqIOmodule passed successfully after this change.Thanks!