Skip to content

Conversation

@jit-ci
Copy link

@jit-ci jit-ci bot commented Oct 24, 2023

No description provided.

Copy link
Author

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

type = "redirect"
redirect {
port = "80"
protocol = "HTTP"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Iac Misconfig Detection Terraform

Type: Aws Application Load Balancer (Alb) Should Not Listen On Http

Description: AWS Application Load Balancer (alb) should not listen on HTTP

Severity: HIGH

Learn more about this issue


Fix suggestion:

This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.

Suggestion guidelines

Issue Type: IncorrectValue
Expected value: 'default_action.redirect.protocol' should be equal to 'HTTPS'
Actual value: 'default_action.redirect.protocol' is equal 'HTTP'

Suggested change
protocol = "HTTP"
protocol = "HTTPS"

Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant