Bond parsing in PDB format now uses chain ids correctly #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks fine! The vintage engine is required to run existing tests in Junit3/4. I think if all tests use junit5 only, then it can be removed. Maybe the Contributing.md file could be updated to say tests are running using junit4/5 and writing new tests in junit 5 is encouraged? |
Contributor
Author
|
The CI problems are still not solved. I'll merge this after testing it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #943
@richarda23 I've created a new integration test with junit5. Can you double check that's ok? Question: is the junit-vintage-engine required?