Multiple OBO altids fix for #964 #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemduarte
approved these changes
Aug 28, 2021
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
LGTM thanks! Again, let's wait for #958 to be resolved before merging.
Contributor
|
The CI problems are still not solved. I'll merge this after testing it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables multiple alt_ids by storing the annotation value as a List rather than a single item.
There seems to be no restriction in Annotation as to what can be values.
But calling code would need to know somehow that getting an Annotation keyed by alt_id would return a list.
A new test added and minor reformatting/updating of code