#855 make or read genbank file error when feature spans zero point of circular sequence #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions spanning sequence end.
…ters more may be less readable I changed strategy and configured parser class.
…anning the end point. Location contract wants sublocations
…ger. This fix should be propagated to Location class and related.
josemduarte
requested changes
May 5, 2020
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me. Only one minor comment
biojava-core/src/main/java/org/biojava/nbio/core/sequence/location/InsdcLocations.java
Show resolved
Hide resolved
Contributor
Contributor
Author
|
By the way, I may just miss some pieces or a different way to represent it, does AbstractSequence misses a kind of isCircular property? Would it be good to add? |
Contributor
Author
Contributor
|
I will merge this by end of week if there are no other comments. I'll then produce a new release. |
Member
|
Thank you @josemduarte @paolopavan, I will review and test this week. |
Contributor
|
@heuermh any comments? or shall we merge? |
sbliven
approved these changes
May 29, 2020
Member
|
Looks good to me. Thanks @paolopavan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #855