Skip to content

Update slf4j/log4j dependencies #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josemduarte merged 1 commit into from
Apr 18, 2020
Merged

Update slf4j/log4j dependencies #869

josemduarte merged 1 commit into from
Apr 18, 2020

Conversation

@sjaenick
Copy link
Contributor

@sjaenick sjaenick commented Apr 13, 2020

slf4j/log4j dependencies are quite old (>3 years), this PR updates

slf4j update 1.7.25 -> 1.7.30
log4j update 2.6.2 -> 2.13.1

@sjaenick
slf4j update 1.7.25 -> 1.7.30
3ac8e06 
log4j update 2.6.2 -> 2.13.1
@heuermh
Copy link
Member

heuermh commented Apr 14, 2020

Hello @sjaenick! Thank you for the pull request. The Travis build failure is unrelated

[ERROR] testLocal(org.biojava.nbio.structure.test.symmetry.TestQuatSymmetryDetectorExamples)  Time elapsed: 28.586 s  <<< FAILURE!

org.junit.ComparisonFailure: Unexpected global symmetry in BIO:3R8R:1 expected:<[C1]> but was:<[D5]>
	at org.biojava.nbio.structure.test.symmetry.TestQuatSymmetryDetectorExamples.testLocal(TestQuatSymmetryDetectorExamples.java:259)

See also #867 (comment)

We'll try to get that resolved shortly and then will merge this pull request.

@josemduarte josemduarte merged commit e18bf4f into biojava:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josemduarte josemduarte josemduarte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjaenick @heuermh @josemduarte