Skip to content

Conversation

@josemduarte
Copy link
Contributor

Travis still fails at downloading external resources quite often (especially ftp resources). This change would cache some of the resources across builds.

I haven't tested this yet. The build of this PR will do the test.

It is still possible to clear the cache when needed, see https://docs.travis-ci.com/user/caching/#Clearing-Caches

@josemduarte josemduarte requested a review from sbliven July 2, 2018 18:09
@sbliven
Copy link
Member

sbliven commented Jul 9, 2018

This is not an ideal solution. We often first discover changes to databases when Travis fails. However, the frequent network failures are an even bigger problem. Let's try this and see if it cuts down on the CI failures.

@josemduarte
Copy link
Contributor Author

Indeed I'm not convinced that this is the best solution. But as we are having so many failures I was eager to add some mitigation.

I've found out that one of the frequently failing tests is TestSiftsParsing which uses ftp external resources. Very frequently it just stalls and grinds to a halt, travis then kills the process after 10 minutes of inactivity. Is anyone aware of specific problems with travis and ftp resources?

@sbliven
Copy link
Member

sbliven commented Jul 11, 2018

It looks like FTP isn't supported:

https://docs.travis-ci.com/user/common-build-problems/#FTP-SMTP-other-protocol-does-not-work

It's weird that this used to work though.

Travis blocks FTP so we're avoiding it.
@sbliven sbliven force-pushed the travis-pdb-caching branch from eb8552a to bef2fe2 Compare July 11, 2018 14:54
@sbliven
Copy link
Member

sbliven commented Jul 11, 2018

I added a commit to your branch switching from FTP to HTTP for Sifts.

The only place BioJava still references ftp is in BlastClustReader (ftp://resources.rcsb.org/sequence/clusters/). Maybe @josemduarte or @MrColeC could enable http or https for that server? On the other hand, it doesn't appear to be tested (👎) so hopefully travis will be OK.

@MrColeC
Copy link

MrColeC commented Jul 11, 2018

@sbliven It is not advertised, but has existed for ~2 years. You can get the sequence clusters here via HTTPS or HTTP

https://cdn.rcsb.org/resources/sequence/clusters/bc-95.out

You cannot get a directory listing, but if you know the file names you can pull them.

@josemduarte
Copy link
Contributor Author

Thank you @sbliven and @MrColeC ! Actually did not realise that EBI were providing the data over http too.

Since most of the problems came from those ftp resources, I'd propose for now to close this Pull Request and create a new one with only the ftp->http change. If problems with building become bad again we can revisit adding the pdb dirs caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants