several fixes for biological assemblies calculations #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemduarte
approved these changes
Oct 7, 2017
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
Looks good, thank you!
lafita
reviewed
Oct 10, 2017
Member
lafita
left a comment
lafita
left a comment
There was a problem hiding this comment.
Thanks for the fixes! I just found a bug.
| */ | ||
| public List<Subunit> getSubunits() { | ||
| return Collections.unmodifiableList(subunits); | ||
| if (subunits != null) |
Member
There was a problem hiding this comment.
Subunits should never be null. The bug is that some code is missing from the helical symmetry constructor. The right fix is to add the following code into line 101:
subunits = new ArrayList();
for (SubunitCluster c : clusters) {
subunits.addAll(c.getSubunits());
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.