Fixing bug in Chromosome Mapping Tools #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemduarte
reviewed
Aug 15, 2017
| public static final String CDS = "CDS"; | ||
|
|
||
|
|
||
| public static int base = 1; |
Contributor
There was a problem hiding this comment.
Shouldn't this be a member of this class rather than a static?
josemduarte
requested changes
Aug 15, 2017
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
Looks good thanks! Some minor comments only
| import static junitx.framework.ComparableAssert.assertEquals; | ||
|
|
||
| /** | ||
| * Created by Yana Valasatava on 8/14/17. |
Contributor
There was a problem hiding this comment.
Could you use the @author tag here and also write a minimal explanation of what the test does?
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import static junitx.framework.ComparableAssert.assertEquals; |
Contributor
There was a problem hiding this comment.
This should be imported from package org.junit.assert. I usually simply do this:
import static org.junit.Assert.*;which imports all the assert static methods.
Contributor
Author
|
Is there anything else I can improve? |
josemduarte
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug in calculating CDS length