Skip to content

Updating to latest RCSB URLs for 4.2.x #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josemduarte merged 5 commits into from
Jul 6, 2017
Merged

Updating to latest RCSB URLs for 4.2.x #683

josemduarte merged 5 commits into from
Jul 6, 2017

Conversation

@josemduarte
Copy link
Contributor

@josemduarte josemduarte commented Jul 6, 2017

No description provided.

@lafita
Copy link
Member

lafita commented Jul 6, 2017 •
edited
Loading

Some tests are still failing:

Failed tests: 
  ChemCompTest.testChangingProviders:144 expected:<[MEA]> but was:<[???]>
  ChemCompTest.testMEA:72  one letter code is not correct expected:<[F]> but was:<[?]>
  ChemCompTest.testPRR:104 Got back group of wrong type! org.biojava.nbio.structure.HetatomImpl
  TestAsaCalc.testAsa3PIU:69 expected:<17462.0> but was:<17638.907170976614>
  TestParseMmCIFLigands.testLigandConnections:65 expected:<172> but was:<0>
  TestParseMmCIFLigands.testMultipleConformations:109 expected:<114> but was:<0>

Any ideas?

@josemduarte
Copy link
Contributor Author

josemduarte commented Jul 6, 2017

Still working on it... Locally it worked ok for me but not in travis, weird.

@lafita
Copy link
Member

lafita commented Jul 6, 2017 •
edited
Loading

The master branch also fails on travis but passes for me locally. I can't tell from the travis log what is going wrong, though.

If it works locally for you we can assume it is alright.

@josemduarte
Copy link
Contributor Author

josemduarte commented Jul 6, 2017

Ok it's due to the use of https instead of http. Travis has some different settings for that (or perhaps a different java vm?) and it fails. I'll change to http.

@josemduarte josemduarte merged commit 9291fab into biojava:bugfixes-4.2 Jul 6, 2017
@sbliven sbliven mentioned this pull request Sep 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josemduarte @lafita