Cherry-pick the c5fa135 commit #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafita
reviewed
Jul 6, 2017
Member
lafita
left a comment
lafita
left a comment
There was a problem hiding this comment.
Is this commit c5fa135 from the master branch (biojava version 5)?
Why is it interesting to include it in the bugfixes branch? To me it looks like a new feature.
Contributor
|
It's really just a tiny extension to the API. We need it to properly support software pipelines related to uniprot mapping that depended on 4.2.x |
Member
|
Alright sounds good! I was just wondering because I remember it was really hard to get the gaps from the biojava alignments. |
Contributor
Author
|
There is a pull request #491 included but that’s not entirely on purpose…I added it while merging in some functionality needed by uniprot project and we decided to keep it.
If it’s ready for release we just keep keeping it.
Yana
… On Jul 6, 2017, at 9:15 AM, Aleix Lafita ***@***.***> wrote:
Alright sounds good! I was just wondering because I remember it was really hard to get the gaps from the biojava alignments.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#682 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQAmlIEqVtax1zC-hJeVN92BClx_BaUpks5sLQgdgaJpZM4OO3O9>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.