Skip to content

Add methods for reading RNA sequences.#660

Merged
josemduarte merged 1 commit into
biojava:masterfrom
heuermh:read-rna-sequences
May 31, 2017
Merged

Add methods for reading RNA sequences.#660
josemduarte merged 1 commit into
biojava:masterfrom
heuermh:read-rna-sequences

Conversation

@heuermh

@heuermh heuermh commented Apr 27, 2017

Copy link
Copy Markdown
Member

Added methods for reading RNA sequences by copy paste search replace.

@sbliven sbliven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josemduarte

Copy link
Copy Markdown
Contributor

There are some issues with the tests, most likely unrelated to this. I'll try restarting them again.

@lafita

lafita commented May 11, 2017

Copy link
Copy Markdown
Member

I think the errors are with CATH tests (a NPE). I will run the tests locally to see if they pass.

Also, could we add some tests for the new methods? Just copying the DNA tests and replacing them with RNA would be enough.

@lafita lafita added the enhancement Improvement of existing code or method label May 11, 2017
@lafita

lafita commented May 11, 2017

Copy link
Copy Markdown
Member

Tests pass locally and I see that also in travis. Looks ok to me although would be nice to include the tests.

@heuermh

heuermh commented May 11, 2017

Copy link
Copy Markdown
Member Author

Sure, I can add some tests. I was hunting for some Genbank RNA files in the wild but I couldn't find any, they aren't usually represented that way.

@lafita

lafita commented May 11, 2017

Copy link
Copy Markdown
Member

Do you mean an RNA database? I know about RNAcentral for non-coding RNA sequences http://rnacentral.org

Also NCBI seems to have mRNA and tRNA sequences, like https://www.ncbi.nlm.nih.gov/nuccore/AY892647.1

@heuermh

heuermh commented May 11, 2017

Copy link
Copy Markdown
Member Author

Specifically I meant Genbank sequences using the RNA alphabet. You can find FASTA formatted RNA sequences in the RNA alphabet in some of those databases, but Genbank RNA sequences (like AY892647.1 you linked) are represented in the DNA alphabet.

@lafita

lafita commented May 11, 2017

Copy link
Copy Markdown
Member

True, I wonder why though! Seems that a simple U for T replacement is needed.

@josemduarte

Copy link
Copy Markdown
Contributor

So it seems that we can't have an RNA file for the test, right? I'll merge for the moment, but it'd be good to have a test at some point.

@josemduarte josemduarte merged commit be50915 into biojava:master May 31, 2017
@heuermh heuermh deleted the read-rna-sequences branch March 6, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of existing code or method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants