Proposed fix for #355#567
Merged
josemduarte merged 4 commits intobiojava:masterfrom Aug 28, 2016
andviane:master
Merged
Conversation
Author
|
The second 'Cleanup' commit was only intended to restore the by chance applied formatting, without any changes in the code itself. Really no idea why it failed. Maybe something system dependent? There are messages about the PDB_DIR property being accessible during the build. |
Contributor
|
Thanks! Could you merge in the TestIssue355 branch? or otherwise simply add the test manually? We need to make sure that the test always runs. I suspect Travis failures are related to some download problem. Let´s see if it builds after you push another commit. |
Author
|
Ok done. |
Contributor
|
Thanks! I'll merge it |
Contributor
|
We'll need to add this to the bugfixes branch too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interval intersection is wrongly computed. Here is the proposed alternative implementation. It passes the new TestIssue355 Unit test that exists in another branch.