Fix for issue 544 #546
Merged
Fix for issue 544 #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thanks! |
Member
|
Thank you @josemduarte! CathDomainDescriptionFile: http://download.cathdb.info/cath/releases/latest-release/v4_1_0/cath-classification-data/cath-domain-description-file-v4_1_0.txt I will make a direct commit to master with the names. Should we include these changes to 4.2-bugfixes branch too? |
lafita
added a commit
that referenced
this pull request
Jul 29, 2016
CathNames and CathDomainDescriptionFile
Member
|
Yes, I think that would be useful |
josemduarte
pushed a commit
that referenced
this pull request
Jul 29, 2016
CathNames and CathDomainDescriptionFile
Contributor
Author
|
Thanks @lafita , I've just cherry-picked it back to bugfixes-4.2. There should be a release with all this later today. |
andreasprlic
added a commit
to andreasprlic/biojava
that referenced
this pull request
Aug 15, 2016
* 'master' of github.com:biojava/biojava: (36 commits) Add some tests for negative residue ranges Minor javadoc & warnings fixes Fix compilation errors from merge Fix MultipleAlignmentJmol resizing bug Fixed bug where bonds from struct conn records were not made for multiple models. Latest ECOD now contains string quotes around some data fields. Need to remove them for junit tests to parse. update test for type of group based on comments from @josemduarte Fixing cath urls according to their final layout [maven-release-plugin]prepare for next development iteration [maven-release-plugin]prepare release biojava-4.2.4 new utility class for chromosome mappings. adding new dependency on guava new utility class for chromosome mappings. new utility class for chromosome mappings. Adding test for genome mapping Complete new CATH file names biojava#546 and biojava#544 Fixing biojava#544 and improving logging Some work towards fixing biojava#544 Back-porting cloning fix (see biojava#541) into bugfixes-4.2 biojava#542 changing default SCOP download location to Berkeley- SCOP. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the test problems for the moment. I didn't get a reply from cath yet, so don't know if the old URL is gone for good. In any case the new server layout seems to be well thought and solid, it looks like it is there to stay. One problem is I couldn't find the new file names for CathDomainDescriptionFile and CathNames, so that's a TODO for later.