Fix for issue 517 #541
Merged
Fix for issue 517 #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemduarte
added a commit
that referenced
this pull request
Jul 28, 2016
Contributor
Author
|
So the tests have been failing a few times and still are. I've solved some of the issues related to the changes introduced in #537 and pushed the commits. However the CATH server is not working at the moment and the build still fails because of that. In any case this solves issue #517, so the related tests that were failing for the last week or so are now fine with this. I've also back-ported the cloning fix to bugfixes-4.2 (see 46b30b3) |
Member
|
Thank you @josemduarte! I checked out your branch and the tests work fine. From my side, this PR can be merged. About the CATH problem I created a new issue #544. |
Member
|
merging although unit tests fail (related to CATH, so not related to this pull request( |
andreasprlic
added a commit
to andreasprlic/biojava
that referenced
this pull request
Aug 15, 2016
* 'master' of github.com:biojava/biojava: (36 commits) Add some tests for negative residue ranges Minor javadoc & warnings fixes Fix compilation errors from merge Fix MultipleAlignmentJmol resizing bug Fixed bug where bonds from struct conn records were not made for multiple models. Latest ECOD now contains string quotes around some data fields. Need to remove them for junit tests to parse. update test for type of group based on comments from @josemduarte Fixing cath urls according to their final layout [maven-release-plugin]prepare for next development iteration [maven-release-plugin]prepare release biojava-4.2.4 new utility class for chromosome mappings. adding new dependency on guava new utility class for chromosome mappings. new utility class for chromosome mappings. Adding test for genome mapping Complete new CATH file names biojava#546 and biojava#544 Fixing biojava#544 and improving logging Some work towards fixing biojava#544 Back-porting cloning fix (see biojava#541) into bugfixes-4.2 biojava#542 changing default SCOP download location to Berkeley- SCOP. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the discussion in #517 the issue was with seqres groups not having set the chem component. The mmtf inflator was actually setting them correctly (without a 3-letter code though, a known limitation), but the problem was in cloning of groups (needed to create the bioassembly) where the chem comp wasn't cloned properly.