Merged
Conversation
Fixed also compilation error. One test still fails.
The oligomeric size annotation in file is now ignored (often inconsistent, sometimes not even present)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issues discussed in #476, removing the bioassembly providers and making loading of bioassemblies much more streamlined. The removal of the providers should have few effects as the main interface to access them was
StructureIO.getBioAssemblyand that interface hasn't changed (only some more methods added).It also adds an option to get bioassemblies as "flattened" single model structures with chains renamed, as discussed in #462. The default behavior (set in constant
AtomCache.DEFAULT_BIOASSEMBLY_STYLE) is what we had until now: biossemblies are represented as multimodels.